[AMORO-4235] Handling stale ack gracefully when task is reset by OptimizerKeeper#4239
Open
zhangwl9 wants to merge 1 commit into
Open
[AMORO-4235] Handling stale ack gracefully when task is reset by OptimizerKeeper#4239zhangwl9 wants to merge 1 commit into
zhangwl9 wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4239 +/- ##
============================================
+ Coverage 23.09% 30.14% +7.04%
- Complexity 2706 4382 +1676
============================================
Files 463 680 +217
Lines 42826 55272 +12446
Branches 6044 7092 +1048
============================================
+ Hits 9891 16662 +6771
- Misses 32076 37352 +5276
- Partials 859 1258 +399
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…ter task reset by OptimizerKeeper
zhangwl9
changed the title
zhangwl9
force-pushed
the
AMORO-fixup-task-reset-bug-dev
branch
from
9f09d75 to
7721dc0
Compare
github-actions
Bot
added
module:ams-optimizer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Close #4235.
Brief change log
When OptimizerKeeper detects an optimizer is expired and resets tasks by clearing
the task token, the Optimizer may still poll and attempt to ack those stale tasks.
Previously this caused ERROR logs and unexpected behavior.
This fix adds exception detection in OptimizerExecutor.ackTask() to recognize the
"Task has been reset" exception. When detected:
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation